From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: Re: [PATCH] 8250 driver interrupt sharing Date: Thu, 28 Oct 2004 12:18:45 +0100 Sender: linux-serial-owner@vger.kernel.org Message-ID: <20041028121845.D3327@flint.arm.linux.org.uk> References: <200410281301.59584.thomas.koeller@baslerweb.com> <20041028120026.B3327@flint.arm.linux.org.uk> <200410281317.41817.thomas.koeller@baslerweb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([212.18.232.186]:49681 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S262970AbUJ1LSt (ORCPT ); Thu, 28 Oct 2004 07:18:49 -0400 Content-Disposition: inline In-Reply-To: <200410281317.41817.thomas.koeller@baslerweb.com>; from thomas.koeller@baslerweb.com on Thu, Oct 28, 2004 at 01:17:41PM +0200 List-Id: linux-serial@vger.kernel.org To: Thomas Koeller Cc: linux-serial@vger.kernel.org On Thu, Oct 28, 2004 at 01:17:41PM +0200, Thomas Koeller wrote: > On Thursday 28 October 2004 13:00, Russell King wrote: > > On Thu, Oct 28, 2004 at 01:01:58PM +0200, Thomas Koeller wrote: > > > here is a little patch that causes the driver to no longer pretend having > > > handled an interrupt if none of the ports actually interrupted. I am > > > currently doing a port to a platform where I want (actually, have) to > > > share a single interrupt between serial ports and other devices. The > > > patch is against kernel version 2.6.9. > > > > You can only share serial port interrupts with other devices if the > > interrupt controller input is level sensitive rather than edge > > sensitive. If it is edge sensitive, then you'll run into problems. > > On my target platform, interrupts are indeed level sensitive, so this > should not be a problem (for me). Ok - that's fine. > Does this problem somehow invalidate my patch? Not really, but if you were using edge triggering, that would invalidate your idea that you could share serial port interrupts reliably with other devices. > Even if interrupts were edge sensitive, returning IRQ_NONE should ok, > or not? It should be fine. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core