Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Chris Wedgwood <cw@f00f.org>
To: linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix for 8250.c *wrongly* detecting XScale UART(s) on x86 PC
Date: Sun, 6 Mar 2005 02:54:51 -0800	[thread overview]
Message-ID: <20050306105451.GA4204@taniwha.stupidest.org> (raw)
In-Reply-To: <20050306101912.A19558@flint.arm.linux.org.uk>

On Sun, Mar 06, 2005 at 10:19:12AM +0000, Russell King wrote:

> If it breaks here (due to your ports being "embraced and extended") it
> could well break elsewhere, and wrapping it in CONFIG_ARM doesn't solve
> that.

Yeah, I forgot other ARM stuff might have regular UART(s) which
potentially would break here too.

> I'm not sure what the solution to this is, but unless we can
> autodetect the port "type", it rather screws the current direction
> of 8250, which has been to move away from port types to a set of
> port capabilities.

Well, as I see it there are three types of serial port knowledge:

(1) Ports we know for (almost) certain we have.  For x86* we can
    probably assume ttyS0 has some fairly standard values like 0x3f8,4
    and if not expect the user to specify otherwise.

(2) Ports we know for (almost) certain we don't have.  We have
    #ifdef's for this in places already.  Basically things like PPC
    and ARM/XScale UARTs won't be found on PCs (though the reverse is
    clearly not true).

(3) Everything else.

If (1) & (2) end up being pretty limited and the bulk of 8250.c is
required for (3) then changing things around probably isn't worth
while at all.

> I wonder if its possible to get hold of any documentation for your
> misdetected serial port...

I assumed it's part of the AMD-768 southbridge but the documentation
for that mentions no UARTs so I wonder if it's an external chip
hanging of the LPC bus?  I'll have a closer look tomorrow if that will
help.

      reply	other threads:[~2005-03-06 10:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-06  9:33 [PATCH] fix for 8250.c *wrongly* detecting XScale UART(s) on x86 PC Chris Wedgwood
2005-03-06 10:19 ` Russell King
2005-03-06 10:54   ` Chris Wedgwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050306105451.GA4204@taniwha.stupidest.org \
    --to=cw@f00f.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox