[2.6 patch] drivers/serial/8250_acpi.c: fix a warning

[2.6 patch] drivers/serial/8250_acpi.c: fix a warning

[Adrian Bunk]

This patch fixes the following warning:

<--  snip  -->

...
  CC      drivers/serial/8250_acpi.o
drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
drivers/serial/8250_acpi.c:51: warning: implicit declaration of function 
`acpi_register_gsi'
...

<--  snip  -->

This patch was already ACK'ed by Bjorn Helgaas.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

This patch was already sent on:
- 5 Apr 2005

--- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old	2005-04-05 15:58:59.000000000 +0200
+++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c	2005-04-05 16:01:47.000000000 +0200
@@ -9,6 +9,7 @@
  * (at your option) any later version.
  */
 
+#include <linux/config.h>
 #include <linux/acpi.h>
 #include <linux/init.h>
 #include <linux/module.h>

Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

[Alexey Dobriyan]

On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote:

> This patch fixes the following warning:

>   CC      drivers/serial/8250_acpi.o
> drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
> drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi'

> --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old
> +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c

> +#include <linux/config.h>

drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols.

Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

[Adrian Bunk]

On Fri, Apr 15, 2005 at 08:10:54PM +0400, Alexey Dobriyan wrote:
> On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote:
> 
> > This patch fixes the following warning:
> 
> >   CC      drivers/serial/8250_acpi.o
> > drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
> > drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi'
> 
> > --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old
> > +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c
> 
> > +#include <linux/config.h>
> 
> drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols.

8250_acpi.c #include's <acpi/acpi_bus.h> which requires config.h .

In the Linux kernel, it's more common to put such header dependencies 
for header files into the C files, but if the ACPI people agree a patch 
to add the #include <linux/config.h> to acpi_bus.h is the other possble 
correct solution for this issue.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

[Herbert Xu]

Adrian Bunk <bunk@stusta.de> wrote:
>
>> drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols.
> 
> 8250_acpi.c #include's <acpi/acpi_bus.h> which requires config.h .
> 
> In the Linux kernel, it's more common to put such header dependencies 
> for header files into the C files, but if the ACPI people agree a patch 

I disagree with this assertion.  Try

grep -l linux/config.h include/linux/*.h | wc -l

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

[Russell King]

On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote:
> In the Linux kernel, it's more common to put such header dependencies 
> for header files into the C files, but if the ACPI people agree a patch 
> to add the #include <linux/config.h> to acpi_bus.h is the other possble 
> correct solution for this issue.

With the exception of linux/config.h.

Do a 'make configcheck' and it'll tell you where linux/config.h is missing
and where it shouldn't be.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

[2.6 patch] ACPI: add two missing config.h #include's

[Adrian Bunk]

On Sat, Apr 16, 2005 at 08:59:23AM +0100, Russell King wrote:
> On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote:
> > In the Linux kernel, it's more common to put such header dependencies 
> > for header files into the C files, but if the ACPI people agree a patch 
> > to add the #include <linux/config.h> to acpi_bus.h is the other possble 
> > correct solution for this issue.
> 
> With the exception of linux/config.h.
> 
> Do a 'make configcheck' and it'll tell you where linux/config.h is missing
> and where it shouldn't be.

OK, then the patch below is the correct solution.

cu
Adrian


<--  snip  -->


This patch fixes the following warning by adding two missing config.h 
#include's:

<--  snip  -->

...
  CC      drivers/serial/8250_acpi.o
drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
drivers/serial/8250_acpi.c:51: warning: implicit declaration of function 
`acpi_register_gsi'
...

<--  snip  -->

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h.old	2005-04-17 19:05:23.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h	2005-04-17 19:05:37.000000000 +0200
@@ -26,6 +26,7 @@
 #ifndef __ACPI_BUS_H__
 #define __ACPI_BUS_H__
 
+#include <linux/config.h>
 #include <linux/kobject.h>
 
 #include <acpi/acpi.h>
--- linux-2.6.12-rc2-mm3-full/include/linux/acpi.h.old	2005-04-17 19:25:51.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/linux/acpi.h	2005-04-17 19:24:54.000000000 +0200
@@ -25,6 +25,8 @@
 #ifndef _LINUX_ACPI_H
 #define _LINUX_ACPI_H
 
+#include <linux/config.h>
+
 #ifdef CONFIG_ACPI
 
 #ifndef _LINUX

Re: [2.6 patch] ACPI: add two missing config.h #include's

[Len Brown]

Applied.

thanks,
-Len

On Sun, 2005-04-17 at 14:19, Adrian Bunk wrote:
> On Sat, Apr 16, 2005 at 08:59:23AM +0100, Russell King wrote:
> > On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote:
> > > In the Linux kernel, it's more common to put such header
> dependencies
> > > for header files into the C files, but if the ACPI people agree a
> patch
> > > to add the #include <linux/config.h> to acpi_bus.h is the other
> possble
> > > correct solution for this issue.
> >
> > With the exception of linux/config.h.
> >
> > Do a 'make configcheck' and it'll tell you where linux/config.h is
> missing
> > and where it shouldn't be.
> 
> OK, then the patch below is the correct solution.
> 
> cu
> Adrian
> 
> 
> <--  snip  -->
> 
> 
> This patch fixes the following warning by adding two missing config.h
> #include's:
> 
> <--  snip  -->
> 
> ...
>   CC      drivers/serial/8250_acpi.o
> drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
> drivers/serial/8250_acpi.c:51: warning: implicit declaration of
> function
> `acpi_register_gsi'
> ...
> 
> <--  snip  -->
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> --- linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h.old      
> 2005-04-17 19:05:23.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h   2005-04-17
> 19:05:37.000000000 +0200
> @@ -26,6 +26,7 @@
>  #ifndef __ACPI_BUS_H__
>  #define __ACPI_BUS_H__
> 
> +#include <linux/config.h>
>  #include <linux/kobject.h>
> 
>  #include <acpi/acpi.h>
> --- linux-2.6.12-rc2-mm3-full/include/linux/acpi.h.old  2005-04-17
> 19:25:51.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/include/linux/acpi.h      2005-04-17
> 19:24:54.000000000 +0200
> @@ -25,6 +25,8 @@
>  #ifndef _LINUX_ACPI_H
>  #define _LINUX_ACPI_H
> 
> +#include <linux/config.h>
> +
>  #ifdef CONFIG_ACPI
> 
>  #ifndef _LINUX
> 
>