Re: [PATCH] make 8250_pnp use pnp_manual_config_dev()

[Adam Belay <ambx1@neo.rr.com>]

On Tue, May 10, 2005 at 10:07:15AM -0300, Aristeu Sergio Rozanski Filho wrote:
> > > Hi,
> > > 	this patch makes 8250_pnp use pnp_manual_config_dev() so
> > > 	pnp_reserve_{io,irq} option will be valid for serial ports too.
> > > 	Please consider applying

pnp_manual_config_dev is intented for drivers that use different
resource assignments than those automatically set by PnP.  It looks
like you're passing the same config back.

Could you please explain your rational here further.

Values already assigned by the BIOS are not checked against reserved
regions.  Is this what you're getting it?  If so, we could have double
detection issues between the PnP protocol and the legacy detection
mechanism.


> > 
> > Please copy this to Adam Belay.  There are some problems with PNP
> > serial ports because they can clash with with standard addresses
> > for x86 ports.

Ideally, I think we should avoid legacy probing if PnPBIOS or ACPI is
available.  When serial console is enabled we could have an exception.
What do you think?

> > 
> > We don't particularly want to reconfigure the standard x86 ports
> > to some other addresses just because we've already detected them
> > and claimed their resources external to PNP.
> OK, adding Adam Belay to CC and attaching the patch again.
> 
> --
> Aristeu

Thanks,
Adam