From: Russell King <rmk@arm.linux.org.uk>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] 8250 PCI Serial driver not always disabling PCI device
Date: Wed, 20 Jul 2005 09:03:23 +0100 [thread overview]
Message-ID: <20050720090323.A1864@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200507200927.06500@bilbo.math.uni-mannheim.de>; from eike-kernel@sf-tec.de on Wed, Jul 20, 2005 at 09:27:05AM +0200
On Wed, Jul 20, 2005 at 09:27:05AM +0200, Rolf Eike Beer wrote:
> I found that pciserial_remove_one() only disables the device if it finds
> private data. This looks suspicious to me. Patch attached.
Makes no difference. If we don't have the private data set, then
we have errored out during the initialisation, and we disabled the
device on the way out. Moreover, the exit function won't even be
called.
So we actually have the guarantee that there will always be private
data here.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-07-20 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-20 7:27 [PATCH] 8250 PCI Serial driver not always disabling PCI device Rolf Eike Beer
2005-07-20 8:03 ` Russell King [this message]
2005-07-20 8:24 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050720090323.A1864@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=eike-kernel@sf-tec.de \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).