From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: rmk+serial@arm.linux.co.uk
Cc: linux-serial@vger.kernel.org
Subject: [PATCH] 8250 PCI Serial driver not always disabling PCI device
Date: Wed, 20 Jul 2005 09:27:05 +0200 [thread overview]
Message-ID: <200507200927.06500@bilbo.math.uni-mannheim.de> (raw)
Hi,
I found that pciserial_remove_one() only disables the device if it finds
private data. This looks suspicious to me. Patch attached.
Eike
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
--- linux-2.6.13-rc3/drivers/serial/8250_pci.c 2005-07-13 06:46:46.000000000
+0200
+++ linux-2.6.13-rc3-eike/drivers/serial/8250_pci.c 2005-07-20
09:16:28.000000000 +0200
@@ -1778,10 +1778,10 @@ static void __devexit pciserial_remove_o
if (quirk->exit)
quirk->exit(dev);
- pci_disable_device(dev);
-
kfree(priv);
}
+
+ pci_disable_device(dev);
}
static int pciserial_suspend_one(struct pci_dev *dev, pm_message_t state)
next reply other threads:[~2005-07-20 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-20 7:27 Rolf Eike Beer [this message]
2005-07-20 8:03 ` [PATCH] 8250 PCI Serial driver not always disabling PCI device Russell King
2005-07-20 8:24 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200507200927.06500@bilbo.math.uni-mannheim.de \
--to=eike-kernel@sf-tec.de \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+serial@arm.linux.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).