From: "Stephan Brodkorb" <stephan-linuxdev@brodkorb.com>
To: linux-kernel@vger.kernel.org
Cc: adobriyan@gmail.com, rubini@ipvvis.unipv.it,
rmk+serial@arm.linux.org.uk, linux-serial@vger.kernel.org,
Markus_Daniel@gmx.de
Subject: [PATCH 1/1] n_r3964 fix - char
Date: Fri, 14 Oct 2005 17:02:42 +0200 [thread overview]
Message-ID: <20051014150238.B105980CD@mail.udag.de> (raw)
--- linux-2.6.14-rc4-orig/drivers/char/n_r3964.c 2005-10-11
03:19:20.000000000 +0200
+++ linux-2.6.14-rc4/drivers/char/n_r3964.c 2005-10-14
15:05:29.589643200 +0200
@@ -695,7 +695,7 @@
{
TRACE_PE("IDLE - got STX but no space in rx_queue!");
pInfo->state=R3964_WAIT_FOR_RX_BUF;
- mod_timer(&pInfo->tmr, R3964_TO_NO_BUF);
+ mod_timer(&pInfo->tmr, jiffies + R3964_TO_NO_BUF);
break;
}
start_receiving:
@@ -705,7 +705,7 @@
pInfo->last_rx = 0;
pInfo->flags &= ~R3964_ERROR;
pInfo->state=R3964_RECEIVING;
- mod_timer(&pInfo->tmr, R3964_TO_ZVZ);
+ mod_timer(&pInfo->tmr, jiffies + R3964_TO_ZVZ);
pInfo->nRetry = 0;
put_char(pInfo, DLE);
flush(pInfo);
@@ -732,7 +732,7 @@
if(pInfo->flags & R3964_BCC)
{
pInfo->state = R3964_WAIT_FOR_BCC;
- mod_timer(&pInfo->tmr, R3964_TO_ZVZ);
+ mod_timer(&pInfo->tmr, jiffies + R3964_TO_ZVZ);
}
else
{
@@ -744,7 +744,7 @@
pInfo->last_rx = c;
char_to_buf:
pInfo->rx_buf[pInfo->rx_position++] = c;
- mod_timer(&pInfo->tmr, R3964_TO_ZVZ);
+ mod_timer(&pInfo->tmr, jiffies + R3964_TO_ZVZ);
}
}
/* else: overflow-msg? BUF_SIZE>MTU; should not happen? */
Hi everybody,
since Revision 1.10 was released the n_r3964 module wasn't able to receive
any data. The reason for that behavior is because there were some wrong
calls of mod_timer(...) in the function receive_char (...).
This patch should fix this problem and was successfully tested with talking
to some kuka industrial robots.
Greetings,
Stephan Brodkorb
reply other threads:[~2005-10-14 15:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051014150238.B105980CD@mail.udag.de \
--to=stephan-linuxdev@brodkorb.com \
--cc=Markus_Daniel@gmx.de \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
--cc=rubini@ipvvis.unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).