From: Russell King <rmk+lkml@arm.linux.org.uk>
To: "Chen, Justin" <justin.chen@hp.com>
Cc: "Helgaas, Bjorn" <bjorn.helgaas@hp.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] new hp diva console port
Date: Mon, 24 Oct 2005 23:35:13 +0100 [thread overview]
Message-ID: <20051024223512.GG26959@flint.arm.linux.org.uk> (raw)
In-Reply-To: <C1BB5827EB7A364EA57B4E8C7C02ADAC054EB8D6@cacexc04.americas.cpqcorp.net>
On Mon, Oct 24, 2005 at 02:38:02PM -0700, Chen, Justin wrote:
> On Monday, October 24, 2005 11:33 AM, Helgaas, Bjorn wrote:
> >It'll be easier to apply this if you follow the guidelines in
> >Documentation/SubmittingPatches. For example, the patch
> >should apply with "patch -p1", add "Signed-off-by:", etc.
>
> Okay, here is the adjusted format and the signature -
>
> This patch adds the new ID 0x132a and configure the new PCI Diva console
> port. This device support only 1 single console UART. Please apply.
> Thanks,
>
> Signed-off-by: Justin Chen <justin.chen@hp.com>
I've actually already committed this, via Andrew Morton. Note,
however, that your mailer has wrapped the patch, so maybe it's
better for you to attach patches (as text/plain) to your emails?
> ------------------------------------------------------------------------
> -------------------------------------------------------
> diff -uprN -X dontdiff linux-vanilla/drivers/serial/8250_pci.c
> ia-26126/drivers/serial/8250_pci.c
> --- linux-vanilla/drivers/serial/8250_pci.c 2005-10-24
> 12:32:01.817851490 -0700
> +++ ia-26126/drivers/serial/8250_pci.c 2005-10-24 12:24:13.628404100
> -0700
> @@ -177,6 +177,7 @@ static int __devinit pci_hp_diva_init(st
> rc = 4;
> break;
> case PCI_DEVICE_ID_HP_DIVA_POWERBAR:
> + case PCI_DEVICE_ID_HP_DIVA_HURRICANE:
> rc = 1;
> break;
> }
> diff -uprN -X dontdiff linux-vanilla/include/linux/pci_ids.h
> ia-26126/include/linux/pci_ids.h
> --- linux-vanilla/include/linux/pci_ids.h 2005-10-24
> 12:31:49.661601638 -0700
> +++ ia-26126/include/linux/pci_ids.h 2005-10-24 12:23:31.366685868
> -0700
> @@ -711,6 +711,7 @@
> #define PCI_DEVICE_ID_HP_DIVA_EVEREST 0x1282
> #define PCI_DEVICE_ID_HP_DIVA_AUX 0x1290
> #define PCI_DEVICE_ID_HP_DIVA_RMP3 0x1301
> +#define PCI_DEVICE_ID_HP_DIVA_HURRICANE 0x132a
> #define PCI_DEVICE_ID_HP_CISSA 0x3220
> #define PCI_DEVICE_ID_HP_CISSB 0x3230
> #define PCI_DEVICE_ID_HP_ZX2_IOC 0x4031
> ------------------------------------------------------------------------
> --------------------------------------------------------------
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-10-24 22:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 21:38 [PATCH] new hp diva console port Chen, Justin
2005-10-24 22:35 ` Russell King [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-10-22 0:30 Chen, Justin
2005-10-24 18:32 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051024223512.GG26959@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=bjorn.helgaas@hp.com \
--cc=justin.chen@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).