From: Russell King <rmk@arm.linux.org.uk>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Geoff Levand <geoffrey.levand@am.sony.com>, linux-serial@vger.kernel.org
Subject: Re: pmac serial_pci_guess_board problem
Date: Fri, 4 Nov 2005 22:50:51 +0000 [thread overview]
Message-ID: <20051104225051.GC12026@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1131140861.29195.13.camel@gaston>
On Sat, Nov 05, 2005 at 08:47:40AM +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2005-11-04 at 13:27 -0800, Geoff Levand wrote:
> > Russell,
> >
> > I found that the serial port probe code in drivers/serial/8250_pci.c
> > no longer works properly for PowerMac G5 in 2.6.14. It seems some new
> > code now takes the PCI device info directly from the G5's Open
> > Firmware. The trouble is that OF sets the address length to 16 bytes,
> > not the expected 8 bytes.
> >
> > Here's a fix, but I'd be interested to hear your comments.
>
> I wouldn't do the ifdef at all ... Why do we bother testing the size
> anyway ? Russell ?
That's the expected size of the ports. Remember this is a heuristic
for finding the correct details of the ports. Some cards seem to
have regions of 16 bytes which aren't serial ports.
I'm _very_ nervous about changing this, especially as it pre-dates
my time and you seem to imply that it's an OF problem. Can't it be
fixed up in a PCI quirk?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-11-04 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 21:27 pmac serial_pci_guess_board problem Geoff Levand
2005-11-04 21:47 ` Benjamin Herrenschmidt
2005-11-04 22:50 ` Russell King [this message]
2005-11-04 22:53 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051104225051.GC12026@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=benh@kernel.crashing.org \
--cc=geoffrey.levand@am.sony.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).