From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Gyorgy Jeney <nog.lkml@gmail.com>
Cc: linux-serial@vger.kernel.org,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] serial: compare mapbase and not membase in find_port
Date: Wed, 4 Jan 2006 18:12:26 +0000 [thread overview]
Message-ID: <20060104181226.GD3119@flint.arm.linux.org.uk> (raw)
In-Reply-To: <221e0ff70601010712u6a0d395dq@mail.gmail.com>
On Sun, Jan 01, 2006 at 04:12:31PM +0100, Gyorgy Jeney wrote:
> From: Gyorgy Jeney
>
> If the 8250_early driver uses bt_ioremap, find_port() is unable to find the
> correct device since the address returned by ioremap is different to that
> returned by bt_ioremap for the same address. Since no more than one device
> occupies the same physical address, compareing the physical addresses should
> be safe.
Really, this should be using uart_match_port(). Fixed to use that.
(And in combination with Ben's patch from November time, it works out
to do the right thing.)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2006-01-04 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-01 15:12 [patch] serial: compare mapbase and not membase in find_port Gyorgy Jeney
2006-01-04 18:12 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060104181226.GD3119@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nog.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).