From: Jon Anders Haugum <jonah@omegav.ntnu.no>
To: Russell King <rmk@arm.linux.org.uk>
Cc: linux-serial@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] serial8250: set divisor register correctly for AMD Alchemy SoC uart. Re-posted.
Date: Wed, 29 Mar 2006 15:39:46 +0200 (CEST) [thread overview]
Message-ID: <20060329153513.L86511@invalid.ed.ntnu.no> (raw)
In-Reply-To: <20060327125423.GA24311@flint.arm.linux.org.uk>
On Mon, 27 Mar 2006, Russell King wrote:
> I'm not sure whether this is a good idea - this is used to detect
> an 16C850 UART, so probably should be kept as is.
>
> In other words, we should use serial_dl_read() / serial_dl_write()
> when we're actually wanting to read or set the actual divisor, but
> not for the autoconfiguration stuff.
Agree.
Should I send you a updated patch?
--
Jon Anders Haugum
prev parent reply other threads:[~2006-03-29 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-27 11:27 [PATCH] serial8250: set divisor register correctly for AMD Alchemy SoC uart. Re-posted Jon Anders Haugum
2006-03-27 12:54 ` Russell King
2006-03-29 13:39 ` Jon Anders Haugum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060329153513.L86511@invalid.ed.ntnu.no \
--to=jonah@omegav.ntnu.no \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox