linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Michael Hordijk <mwh13@pitt.edu>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 2.6.16.18] 8250: Serial console enable Tx fix
Date: Fri, 2 Jun 2006 17:48:46 +0100	[thread overview]
Message-ID: <20060602164846.GF3100@flint.arm.linux.org.uk> (raw)
In-Reply-To: <4477B018.1020101@pitt.edu>

On Fri, May 26, 2006 at 09:49:12PM -0400, Michael Hordijk wrote:
>     Enabling the Tx interrupt from console_write on buggy UART 
>     (UART_BUG_TXEN) breaks console transmit on said UART.  Revert to previous 
> UART_IER restore and use serial8250_start_tx() to cause the transmit path 
> to start and not hang.

Please look at how this got solved in the 2.6.17-rc kernels and
implement the same fix.  Enabling the transmitter at the end of
every console write is just plain buggy and asking for problems.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

      reply	other threads:[~2006-06-02 16:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-27  1:49 [PATCH 2.6.16.18] 8250: Serial console enable Tx fix Michael Hordijk
2006-06-02 16:48 ` Russell King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060602164846.GF3100@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=linux-serial@vger.kernel.org \
    --cc=mwh13@pitt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).