From: Alan Cox <alan@redhat.com>
To: Sergei Organov <osv@javad.com>
Cc: Alan Cox <alan@redhat.com>, linux-serial@vger.kernel.org
Subject: Re: [Q] New tty flip interface doubt.
Date: Fri, 23 Jun 2006 09:16:13 -0400 [thread overview]
Message-ID: <20060623131613.GA27504@devserv.devel.redhat.com> (raw)
In-Reply-To: <87d5d15ie9.fsf@javad.com>
On Thu, Jun 22, 2006 at 07:17:50PM +0400, Sergei Organov wrote:
> I saw this warning, but didn't think that USB urbs must be given DMAable
> memory. Does "transfer_buffer: This buffer has to be allocated as a
> non-pageable contiguous physical memory block" imply the memory must be
> DMAable? If it doesn't, then do tty buffers meet the above cited
> requirement?
At the moment the tty buffers are a chain of buffers meeting that requirement.
> >> - allocate N-bytes data buffer from tty and use it for urb
> >> - submit the urb to USB subsystem
> >> - flip M-bytes of data (M <= N) in USB receive callback.
> >
> > Its doable in theory but is it worth it ?
>
> Well, I don't actually know, -- does your experience suggest it is not?
On a PC almost certainly not because the cost of the accesses is almost nil
with the cache sizes on the CPU die and the performance of the CPU. Embedded
I don't know , you tell me 8)
> If you don't see some hard to avoid obstacles making it difficult to
> implement, I'll probably try to modify tty layer to be able to support
> such a feature to see what it gives.
I've no problem with that. At the moment the allocations all use kmalloc
which should be fine for remapping. At worst you could add an optional
tty->alloc_buf
tty->free_buf
function pointer pair
Alan
prev parent reply other threads:[~2006-06-23 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 12:16 [Q] New tty flip interface doubt Sergei Organov
2006-06-21 13:42 ` Alan Cox
2006-06-22 7:33 ` Sergei Organov
2006-06-22 12:56 ` Alan Cox
2006-06-22 15:17 ` Sergei Organov
2006-06-23 13:16 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623131613.GA27504@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=linux-serial@vger.kernel.org \
--cc=osv@javad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).