* [KJ] few questions on mxser driver (cleanups)
@ 2006-09-28 16:04 Badari Pulavarty
2006-09-28 16:20 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Badari Pulavarty @ 2006-09-28 16:04 UTC (permalink / raw)
To: kernel-janitors, linux-serial; +Cc: alan, rmk+serial
Hi,
I was fixing request_region() error checks and realized few things
about mxser driver (char/mxser.c) - I want to confirm before fixing
them.
1) mxser_get_PCI_conf() and mxser_get_ISA_conf() doesn't check
errors of request_region(). I think these should be checked and
return failures. Can we treat request_region() failures as corresponding
MXSER_ERR_* failures, instead of returning new error code (like -EIO)?
2) mxser_get_PCI_conf() currently doesn't return error - but the
caller checks for various error codes. Is this a oversight or it can't
happen with PCI ? If so, can we nix error checking at the caller ?
Thanks,
Badari
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: few questions on mxser driver (cleanups)
2006-09-28 16:04 [KJ] few questions on mxser driver (cleanups) Badari Pulavarty
@ 2006-09-28 16:20 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2006-09-28 16:20 UTC (permalink / raw)
To: Badari Pulavarty; +Cc: kernel-janitors, linux-serial, rmk+serial, alan
On Thu, Sep 28, 2006 at 09:04:15AM -0700, Badari Pulavarty wrote:
> 1) mxser_get_PCI_conf() and mxser_get_ISA_conf() doesn't check
> errors of request_region(). I think these should be checked and
> return failures. Can we treat request_region() failures as corresponding
> MXSER_ERR_* failures, instead of returning new error code (like -EIO)?
I've as much idea as you do, and no hardware to test sorry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-09-28 16:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-28 16:04 [KJ] few questions on mxser driver (cleanups) Badari Pulavarty
2006-09-28 16:20 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).