From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Subject: Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master Date: Mon, 5 Feb 2007 21:59:01 +0000 Message-ID: <20070205215901.7344c954@localhost.localdomain> References: <45C77B61.1080209@pmc-sierra.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:42534 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S933478AbXBEVs0 (ORCPT ); Mon, 5 Feb 2007 16:48:26 -0500 In-Reply-To: <45C77B61.1080209@pmc-sierra.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Marc St-Jean Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org > unsigned char hub6; /* this should be in the 8250 driver */ > unsigned char unused[3]; > + void *data; /* generic platform data pointer */ > }; Convention is "private_data" > > /* > diff --git a/include/linux/serial_reg.h b/include/linux/serial_reg.h > index 3c8a6aa..b3550cc 100644 > --- a/include/linux/serial_reg.h > +++ b/include/linux/serial_reg.h > @@ -37,6 +37,7 @@ #define UART_IIR_MSI 0x00 /* Modem stat > #define UART_IIR_THRI 0x02 /* Transmitter holding register empty */ > #define UART_IIR_RDI 0x04 /* Receiver data interrupt */ > #define UART_IIR_RLSI 0x06 /* Receiver line status interrupt */ > +#define UART_IIR_BUSY 0x07 /* DesignWare APB Busy Detect */ Please move this down a line to break it from "official" values and call it DESIGNWARE_UART_IIR_BUSY, so it is obviously designware specific. Otherwise looks much less invasive and messy