From: Randy Dunlap <randy.dunlap@oracle.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Keith Owens <kaos@ocs.com.au>, Len Brown <lenb@kernel.org>,
Adam Belay <ambx1@neo.rr.com>,
Matthieu CASTET <castet.matthieu@free.fr>,
Jean Tourrilhes <jt@hpl.hp.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Ville Syrjala <syrjala@sci.fi>,
Russell King <rmk+serial@arm.linux.org.uk>,
linux-serial@vger.kernel.org, Samuel Ortiz <samuel@sortiz.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 4/5] smsc-ircc2: add PNP support
Date: Wed, 4 Apr 2007 16:16:50 -0700 [thread overview]
Message-ID: <20070404161650.e05049e4.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20070404224609.042716000@ldl.fc.hp.com>
On Wed, 04 Apr 2007 16:45:40 -0600 Bjorn Helgaas wrote:
> Index: w/drivers/net/irda/smsc-ircc2.c
> ===================================================================
> --- w.orig/drivers/net/irda/smsc-ircc2.c 2007-04-04 13:45:18.000000000 -0600
> +++ w/drivers/net/irda/smsc-ircc2.c 2007-04-04 13:47:00.000000000 -0600
> @@ -79,6 +79,10 @@
> MODULE_DESCRIPTION("SMC IrCC SIR/FIR controller driver");
> MODULE_LICENSE("GPL");
>
> +static int smsc_nopnp;
> +module_param_named(nopnp, smsc_nopnp, bool, 0);
> +MODULE_PARM_DESC(nopnp, "Do not use PNP to detect controller settings");
Document this parameter (like you did "legacy_serial.force" in the
other patch -- thanks).
> #define DMA_INVAL 255
> static int ircc_dma = DMA_INVAL;
> module_param(ircc_dma, int, 0);
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-04-04 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 22:45 [patch 0/5] PNP: convert x86 legacy serial to platform devs, add SMC IR PNP probe Bjorn Helgaas
2007-04-04 22:45 ` [patch 1/5] PNP: notice whether we have PNP devices (PNPBIOS or PNPACPI) Bjorn Helgaas
2007-04-04 22:45 ` [patch 2/5] PNP: workaround HP BIOS defect that leaves SMCF010 device partly enabled Bjorn Helgaas
2007-04-04 22:45 ` [patch 3/5] smsc-ircc2: tidy up module parameter checking Bjorn Helgaas
2007-04-04 22:45 ` [patch 4/5] smsc-ircc2: add PNP support Bjorn Helgaas
2007-04-04 23:16 ` Randy Dunlap [this message]
2007-04-05 18:45 ` Bjorn Helgaas
2007-04-04 22:45 ` [patch 5/5] x86, serial: convert legacy COM ports to platform devices Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070404161650.e05049e4.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=ambx1@neo.rr.com \
--cc=bjorn.helgaas@hp.com \
--cc=castet.matthieu@free.fr \
--cc=jt@hpl.hp.com \
--cc=kaos@ocs.com.au \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rmk+serial@arm.linux.org.uk \
--cc=samuel@sortiz.org \
--cc=syrjala@sci.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).