Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: minyard@acm.org
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH] Provide better abstraction for the serial drivers to xmit buf and tty
Date: Wed, 18 Apr 2007 10:20:27 +0100	[thread overview]
Message-ID: <20070418102027.0e1edb2b@the-village.bc.nu> (raw)
In-Reply-To: <20070418045423.GA12136@localdomain>

> The basic reason for all this is to eventually allow the low-level
> serial drivers to function without a uart_info structure being
> allocated.  This will allow the serial console, debuggers like kgdb,
> and the IPMI serial driver to use one interface to the uart code and

Its cheaper to allocate a uart_info that keep doing all the checks, at
least for port->info. I can see why you want to avoid port->info->tty as
a debugger can end up running before the tty layer and that would be hard
to work around.

For the other macros - the macros are more efficient than the equivalent
inline code generation at least for some gccs.

Do you really need any of this change but to check info->tty ?

Alan


  reply	other threads:[~2007-04-18  9:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-18  4:54 [PATCH] Provide better abstraction for the serial drivers to xmit buf and tty Corey Minyard
2007-04-18  9:20 ` Alan Cox [this message]
2007-04-18 16:15   ` Corey Minyard
2007-04-18 19:12     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070418102027.0e1edb2b@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=minyard@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox