From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
izumi <izumi2005@soft.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH][BUG] Fix possible NULL pointer access in 8250 serial driver
Date: Wed, 18 Apr 2007 20:18:12 +0100 [thread overview]
Message-ID: <20070418191812.GA21211@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1176884513.3945.54.camel@kane-linux>
On Wed, Apr 18, 2007 at 05:21:53PM +0900, Kenji Kaneshige wrote:
> > I'd imagine that other serial drivers might get upset having their
> > ->get_mcrtl() called prior to being opened. Perhaps we should be fixing
> > this in uart_read_proc()?
> >
>
> I looked at other serial drivers and I could not find any other
> drivers which accesses port->info in their ->get_mctrl(). This
> is why we fix this problem in 8250 driver. But if there is a
> possibility that other drivers accesses port->info in their
> ->get_mctrl(), we should be fixing this in uart_read_proc(), as
> you said.
NAK. This means that you change the list of ports available on the
machine to be limited to only those which are currently open. Utterly
useless for debugging, where you normally want people to dump the
contents of /proc/tty/driver/*.
The original patch was better.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-04-18 19:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 2:15 [PATCH][BUG] Fix possible NULL pointer access in 8250 serial driver izumi
2007-04-17 5:52 ` Andrew Morton
2007-04-18 8:21 ` Kenji Kaneshige
2007-04-18 16:16 ` Andrew Morton
2007-04-18 19:18 ` Russell King [this message]
2007-04-19 2:28 ` izumi
2007-04-19 5:08 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070418191812.GA21211@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=izumi2005@soft.fujitsu.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).