From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: minyard@acm.org
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/8] serial 8250: move push calls out of lock
Date: Thu, 26 Apr 2007 21:35:17 +0100 [thread overview]
Message-ID: <20070426213517.3d55558e@the-village.bc.nu> (raw)
In-Reply-To: <20070426184620.GA25521@localdomain>
On Thu, 26 Apr 2007 13:46:20 -0500
Corey Minyard <minyard@acm.org> wrote:
> Ok, again trying this out with a new approach.
>
> Subject: serial 8250: move push calls out of lock
>
> Due to previous changes in the 8250 driver, the call to
> tty_flip_buffer_push is now done with interrupts disabled. Not really
> a huge deal, but sub-optimal.
This is actually a very good idea as it means you don't have to deal with
the problems with low_latency causing re-entry into the driver under the
lock so its conceptually much easier to follow the locking
Acked-by: Alan Cox <alan@redhat.com>
prev parent reply other threads:[~2007-04-26 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 18:46 [PATCH 1/8] serial 8250: move push calls out of lock Corey Minyard
2007-04-26 20:35 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070426213517.3d55558e@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-serial@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox