From: David Miller <davem@davemloft.net>
To: mark@mtfhpc.demon.co.uk
Cc: wli@holomorphy.com, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org, linux-serial@vger.kernel.org,
jengelh@linux01.gwdg.de
Subject: Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed
Date: Sat, 28 Apr 2007 21:01:47 -0700 (PDT) [thread overview]
Message-ID: <20070428.210147.111207684.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0704281529090.8157@mtfhpc.demon.co.uk>
Your patch is extremely mangled, please try to email it to yourself
and apply it if in doubt.
Furthermore, the comment your patch adds is unnecessary. That kind of
text belongs in the changelog comment, not the code. The changelog is
also where you'll get credit for your change.
There is no reason to play Napoleon in the source files any more now
that we have proper source control and history all these years. :-)
Please fix all of this up and resubmit, thank you.
next prev parent reply other threads:[~2007-04-29 4:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-28 15:11 [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed Mark Fortescue
2007-04-28 15:19 ` Jan Engelhardt
2007-04-29 4:01 ` David Miller [this message]
2007-04-29 22:00 ` Mark Fortescue
2007-05-07 19:27 ` Martin Habets
2007-05-07 23:20 ` David Miller
2007-05-09 18:17 ` [PATCH] " Mark Fortescue
2007-05-09 20:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070428.210147.111207684.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark@mtfhpc.demon.co.uk \
--cc=sparclinux@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox