From: Corey Minyard <minyard@acm.org>
To: Linux Kernel <linux-kernel@vger.kernel.org>,
Russell King <rmk+lkml@arm.linux.org.uk>
Cc: linux-serial@vger.kernel.org
Subject: Serial 8250: clear the lsr_break_flag at open
Date: Mon, 30 Apr 2007 17:08:59 -0500 [thread overview]
Message-ID: <20070430220858.GA28890@localdomain> (raw)
Sorry for the double send, but I messed up on the subject. I'll
get used to mutt one of these days.
I think I've spotted a bug in the 8250 code, but I'm not really
sure. I'm having a hard time understanding why the lsr_break_flag
is necessary.
Subject: Serial 8250: clear the lsr_break_flag at open
The lsr_break_flag in the 8250 driver is not cleared when the port is
opened. This means that on a serial console, if a break has occurred
while the port is closed, the first call to receive_chars() will
result in a break being delivered at that point. Clear the flag at
open to fix the problem.
Signed-off-by: Corey Minyard <minyard@acm.org>
Index: linux-2.6.21/drivers/serial/8250.c
===================================================================
--- linux-2.6.21.orig/drivers/serial/8250.c
+++ linux-2.6.21/drivers/serial/8250.c
@@ -1638,6 +1638,7 @@ static int serial8250_startup(struct uar
up->capabilities = uart_config[up->port.type].flags;
up->mcr = 0;
+ up->lsr_break_flag = 0;
if (up->port.type == PORT_16C950) {
/* Wake up and initialize UART */
next reply other threads:[~2007-04-30 22:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-30 22:08 Corey Minyard [this message]
2007-05-01 9:29 ` Serial 8250: clear the lsr_break_flag at open Russell King
2007-05-01 13:23 ` Corey Minyard
2007-05-03 12:08 ` Russell King
2007-05-04 3:43 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070430220858.GA28890@localdomain \
--to=minyard@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).