From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Corey Minyard <minyard@acm.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: Serial 8250: clear the lsr_break_flag at open
Date: Tue, 1 May 2007 10:29:33 +0100 [thread overview]
Message-ID: <20070501092933.GB18233@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20070430220858.GA28890@localdomain>
On Mon, Apr 30, 2007 at 05:08:59PM -0500, Corey Minyard wrote:
> I think I've spotted a bug in the 8250 code, but I'm not really
> sure.
Yes, clearing lsr_break_flag prior to opening the port is probably a good
thing.
> I'm having a hard time understanding why the lsr_break_flag
> is necessary.
Merely reading the LSR clears status bits. We read the LSR repeatedly
so that we can monitor the transmit FIFO when outputting serial console
messages.
This means that if you have a busy serial console, and you want to send
it a sysrq request, there's a chance that the break flag in the LSR will
be cleared by the transmit FIFO status polling code thereby being lost.
So, we need to remember that status, and we do this via the lsr_break_flag.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-05-01 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-30 22:08 Serial 8250: clear the lsr_break_flag at open Corey Minyard
2007-05-01 9:29 ` Russell King [this message]
2007-05-01 13:23 ` Corey Minyard
2007-05-03 12:08 ` Russell King
2007-05-04 3:43 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070501092933.GB18233@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).