From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Habets Subject: Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed Date: Mon, 7 May 2007 20:27:11 +0100 Message-ID: <20070507192711.GA27915@palantir8> References: <20070428.210147.111207684.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: sparclinux-owner@vger.kernel.org To: Mark Fortescue Cc: wli@holomorphy.com, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-serial@vger.kernel.org List-Id: linux-serial@vger.kernel.org Mark, Gave this a spin on my SS20 today, have the console on the serial port. No problems seen. You will need to provide a signed-off-by line to get it accepted upstream, see Documentation/SubmittingPatches. ffd60050: ttyS0 at MMIO 0xf1100000 (irq = 44) is a zs (ESCC) Console: ttyS0 (SunZilog zs0) ffd60050: ttyS1 at MMIO 0xf1100004 (irq = 44) is a zs (ESCC) ffd60130: Keyboard at MMIO 0xf1000000 (irq = 44) is a zs ffd60130: Mouse at MMIO 0xf1000004 (irq = 44) is a zs Cheers, Martin Habets Ack-by: Martin Habets On Sun, Apr 29, 2007 at 11:00:29PM +0100, Mark Fortescue wrote: > I have altered the patch as advised and I have attached it to prevent my > email client from making a mess of it. > > The attached patch changes the interrupt enable sequence for the sunzilog > driver so that interrupts are not enabled untill after the interrupt > handler has been installed. If this is not done, some SS1 and SS2 sun4c > systems panic on un-handled interrupt before the handler gets installed > preventing boot. > > It also adds in support for the ESCC version of the zilog chips. The ESCC > detection works but the FIFO enable may cause issues with modem and > receive character status. My interpretation of the SCC manual and the code > is that it sould be OK. > > --- > > Regards > Mark Fortescue.