Re: [PATCH] kernel/printk.c: Concerns about the console handover

Russell King
2007-09-21T14:46:02Z

On Fri, Sep 21, 2007 at 03:36:05PM +0100, Maciej W. Rozycki wrote:
> On Fri, 21 Sep 2007, Russell King wrote:
> > You can find the fix in the mbox archive:
> >
> > http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cut/arm:devel.mbox
>
> Hmm, nothing of relevance there.

Hmm, it does help to occasionally run the script which uploads the
patches and stuff. Also I typoed the URL:

http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/arm:devel.mbox

> I see no problem with implementing the ->pm() call as something like:
>
> void zs_pm(struct uart_port uport, unsigned int state, unsigned int oldstate)
> {
> struct zs_port *zport = to_zport(uport);
>
> if (state < 3)
> zport->regs[5] |= TxENAB;
> else
> zport->regs[5] &= ~TxENAB;
> write_zsreg(zport, R5, zport->regs[5]);
> }
>
> itself, but it looks more like a workaround than a fix to me. I'll have
> to think about it and also double-check it is safe. The SCC is about as
> complicated as you can get with a serial port.

You will need the serial patch from the above mbox.

PS, Gerd's bouncing email address removed from the CC line.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/