public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: linux-serial@vger.kernel.org
Subject: [PATCH] serial/8250_pci: Fix a warning in pciserial_resume_one
Date: Wed, 24 Oct 2007 12:17:33 +0200	[thread overview]
Message-ID: <20071024121733.023f962d@hyperion.delvare> (raw)

Fix the following warning:
drivers/serial/8250_pci.c: In function "pciserial_resume_one":
drivers/serial/8250_pci.c:1998: warning: ignoring return value of "pci_enable_device", declared with attribute warn_unused_result

Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
As a side note, I'm curious why the call to pci_enable_device() is
conditioned by priv being set. I'm also not sure if additional cleanups
should be performed if an error occurs.

 drivers/serial/8250_pci.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- linux-2.6.24-rc1.orig/drivers/serial/8250_pci.c	2007-10-24 09:59:47.000000000 +0200
+++ linux-2.6.24-rc1/drivers/serial/8250_pci.c	2007-10-24 12:03:26.000000000 +0200
@@ -1987,6 +1987,7 @@ static int pciserial_suspend_one(struct 
 static int pciserial_resume_one(struct pci_dev *dev)
 {
 	struct serial_private *priv = pci_get_drvdata(dev);
+	int rc;
 
 	pci_set_power_state(dev, PCI_D0);
 	pci_restore_state(dev);
@@ -1995,7 +1996,9 @@ static int pciserial_resume_one(struct p
 		/*
 		 * The device may have been disabled.  Re-enable it.
 		 */
-		pci_enable_device(dev);
+		rc = pci_enable_device(dev);
+		if (rc)
+			return rc;
 
 		pciserial_resume_ports(priv);
 	}


-- 
Jean Delvare

                 reply	other threads:[~2007-10-24 10:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071024121733.023f962d@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox