linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Matteo Croce <technoboy85@gmail.com>,
	linux-mips@linux-mips.org, Florian Fainelli <florian@openwrt.org>,
	Felix Fietkau <nbd@openwrt.org>, Nicolas Thill <nico@openwrt.org>,
	linux-serial@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH][MIPS][5/6]: AR7: serial hack
Date: Tue, 18 Mar 2008 14:01:33 +0000	[thread overview]
Message-ID: <20080318140133.3d41fd87@core> (raw)
In-Reply-To: <20080318133015.GA7239@alpha.franken.de>

> Is there a good reason, why we don't check for BOTH_EMPTY in
> serial8250_console_putchar() ? To match the 2.6.10 behaviour we

A very good one - we have at least 1 byte of FIFO and the serial-ethernet
magic console devices also use that fifo emptying entirely to deduce when
to send a new packet.

> would need that and this would fix the AR7 case without any
> special handling.

If the AR7 is an 8250 why does it need special handling? and indeed why
does serial work on it except for console - or does that fail too.

  parent reply	other threads:[~2008-03-18 14:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200803120221.25044.technoboy85@gmail.com>
2008-03-12  1:30 ` [PATCH][MIPS][5/6]: AR7: serial hack Matteo Croce
2008-03-12  9:31   ` Thomas Bogendoerfer
2008-03-13  0:38     ` Matteo Croce
2008-03-13  8:45       ` Thomas Bogendoerfer
2008-03-14 15:46         ` Matteo Croce
2008-03-15 10:40           ` Thomas Bogendoerfer
2008-03-16 15:45             ` Matteo Croce
2008-03-18 13:30               ` Thomas Bogendoerfer
2008-03-18 13:43                 ` Sergei Shtylyov
2008-03-18 13:49                   ` Sergei Shtylyov
2008-03-18 14:01                 ` Alan Cox [this message]
2008-03-18 15:28                   ` Thomas Bogendoerfer
2008-03-21  1:55               ` Thomas Bogendoerfer
2008-03-27 21:14                 ` Matteo Croce
2008-03-27 21:17                 ` Matteo Croce
2008-03-15 11:38           ` Alan Cox
2008-03-12 11:16   ` Alan Cox
2008-03-13  0:31     ` Matteo Croce
2008-03-13  9:01       ` Thomas Bogendoerfer
2008-03-16 15:27         ` Matteo Croce
2008-03-16 15:49         ` Matteo Croce
     [not found] <200712271919.23577.technoboy85@gmail.com>
2007-12-27 18:27 ` Matteo Croce
2007-12-28 12:13   ` Sergei Shtylyov
     [not found] <200710110248.33028.technoboy85@gmail.com>
2007-10-11  0:59 ` [PATCH][MIPS][5/6] " Matteo Croce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080318140133.3d41fd87@core \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=florian@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nbd@openwrt.org \
    --cc=nico@openwrt.org \
    --cc=technoboy85@gmail.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).