* [2.6 patch] avr32: don't offer SERIAL_8250
@ 2008-04-14 14:17 Adrian Bunk
2008-04-14 14:36 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2008-04-14 14:17 UTC (permalink / raw)
To: hskinnemoen; +Cc: linux-serial, linux-kernel
This patch fixes the following build error:
<-- snip -->
...
CC [M] drivers/serial/8250.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/8250.c:95:24: error: asm/serial.h: No such file or directory
make[3]: *** [drivers/serial/8250.o] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
3cb4ef80d75e118ccfd44f7006aea3db54afb31c diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index b1bbaa0..b0e216d 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -11,7 +11,7 @@ menu "Serial drivers"
# The new 8250/16550 serial drivers
config SERIAL_8250
tristate "8250/16550 and compatible serial support"
- depends on (BROKEN || !SPARC)
+ depends on (BROKEN || !SPARC) && !AVR32
select SERIAL_CORE
---help---
This selects whether you want to include the driver for the standard
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [2.6 patch] avr32: don't offer SERIAL_8250
2008-04-14 14:17 [2.6 patch] avr32: don't offer SERIAL_8250 Adrian Bunk
@ 2008-04-14 14:36 ` Alan Cox
2008-04-14 18:42 ` [2.6 patch] avr32: add include/asm-avr32/serial.h Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2008-04-14 14:36 UTC (permalink / raw)
To: Adrian Bunk; +Cc: hskinnemoen, linux-serial, linux-kernel
On Mon, 14 Apr 2008 17:17:21 +0300
Adrian Bunk <bunk@kernel.org> wrote:
> This patch fixes the following build error:
>
> <-- snip -->
>
> ...
> CC [M] drivers/serial/8250.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/8250.c:95:24: error: asm/serial.h: No such file or directory
> make[3]: *** [drivers/serial/8250.o] Error 1
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> 3cb4ef80d75e118ccfd44f7006aea3db54afb31c diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index b1bbaa0..b0e216d 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -11,7 +11,7 @@ menu "Serial drivers"
> # The new 8250/16550 serial drivers
> config SERIAL_8250
> tristate "8250/16550 and compatible serial support"
> - depends on (BROKEN || !SPARC)
> + depends on (BROKEN || !SPARC) && !AVR32
> select SERIAL_CORE
> ---help---
NAK.
Add an asm/serial.h to the platform as it has PCI so will have 8250 PCI
devices available to it. A copy of the MIPS one should be right.
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread
* [2.6 patch] avr32: add include/asm-avr32/serial.h
2008-04-14 14:36 ` Alan Cox
@ 2008-04-14 18:42 ` Adrian Bunk
2008-04-14 21:56 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2008-04-14 18:42 UTC (permalink / raw)
To: Alan Cox; +Cc: hskinnemoen, linux-serial, linux-kernel
On Mon, Apr 14, 2008 at 03:36:24PM +0100, Alan Cox wrote:
> On Mon, 14 Apr 2008 17:17:21 +0300
> Adrian Bunk <bunk@kernel.org> wrote:
>
> > This patch fixes the following build error:
> >
> > <-- snip -->
> >
> > ...
> > CC [M] drivers/serial/8250.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/8250.c:95:24: error: asm/serial.h: No such file or directory
> > make[3]: *** [drivers/serial/8250.o] Error 1
> >
> > <-- snip -->
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> > ---
> > 3cb4ef80d75e118ccfd44f7006aea3db54afb31c diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> > index b1bbaa0..b0e216d 100644
> > --- a/drivers/serial/Kconfig
> > +++ b/drivers/serial/Kconfig
> > @@ -11,7 +11,7 @@ menu "Serial drivers"
> > # The new 8250/16550 serial drivers
> > config SERIAL_8250
> > tristate "8250/16550 and compatible serial support"
> > - depends on (BROKEN || !SPARC)
> > + depends on (BROKEN || !SPARC) && !AVR32
> > select SERIAL_CORE
> > ---help---
>
> NAK.
>
> Add an asm/serial.h to the platform as it has PCI so will have 8250 PCI
> devices available to it. A copy of the MIPS one should be right.
Patch below.
> Alan
cu
Adrian
<-- snip -->
This patch fixes the following build error with CONFIG_SERIAL_8250:
<-- snip -->
...
CC [M] drivers/serial/8250.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/8250.c:95:24: error: asm/serial.h: No such file or directory
make[3]: *** [drivers/serial/8250.o] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
include/asm-avr32/serial.h | 13 +++++++++++++
1 file changed, 13 insertions(+)
7beddb9fe7aee73227a9796a039cee9583cecc0a diff --git a/include/asm-avr32/serial.h b/include/asm-avr32/serial.h
new file mode 100644
index 0000000..5ecaebc
--- /dev/null
+++ b/include/asm-avr32/serial.h
@@ -0,0 +1,13 @@
+#ifndef _ASM_SERIAL_H
+#define _ASM_SERIAL_H
+
+/*
+ * This assumes you have a 1.8432 MHz clock for your UART.
+ *
+ * It'd be nice if someone built a serial card with a 24.576 MHz
+ * clock, since the 16550A is capable of handling a top speed of 1.5
+ * megabits/second; but this requires the faster clock.
+ */
+#define BASE_BAUD (1843200 / 16)
+
+#endif /* _ASM_SERIAL_H */
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [2.6 patch] avr32: add include/asm-avr32/serial.h
2008-04-14 18:42 ` [2.6 patch] avr32: add include/asm-avr32/serial.h Adrian Bunk
@ 2008-04-14 21:56 ` Alan Cox
2008-04-16 5:53 ` Haavard Skinnemoen
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2008-04-14 21:56 UTC (permalink / raw)
To: Adrian Bunk; +Cc: hskinnemoen, linux-serial, linux-kernel
> 7beddb9fe7aee73227a9796a039cee9583cecc0a diff --git a/include/asm-avr32/serial.h b/include/asm-avr32/serial.h
> new file mode 100644
> index 0000000..5ecaebc
> --- /dev/null
> +++ b/include/asm-avr32/serial.h
> @@ -0,0 +1,13 @@
> +#ifndef _ASM_SERIAL_H
> +#define _ASM_SERIAL_H
> +
> +/*
> + * This assumes you have a 1.8432 MHz clock for your UART.
> + *
> + * It'd be nice if someone built a serial card with a 24.576 MHz
> + * clock, since the 16550A is capable of handling a top speed of 1.5
> + * megabits/second; but this requires the faster clock.
> + */
> +#define BASE_BAUD (1843200 / 16)
> +
> +#endif /* _ASM_SERIAL_H */
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] avr32: add include/asm-avr32/serial.h
2008-04-14 21:56 ` Alan Cox
@ 2008-04-16 5:53 ` Haavard Skinnemoen
0 siblings, 0 replies; 5+ messages in thread
From: Haavard Skinnemoen @ 2008-04-16 5:53 UTC (permalink / raw)
To: Alan Cox; +Cc: Adrian Bunk, linux-serial, linux-kernel
On Mon, 14 Apr 2008 22:56:17 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > +/*
> > + * This assumes you have a 1.8432 MHz clock for your UART.
> > + *
> > + * It'd be nice if someone built a serial card with a 24.576 MHz
> > + * clock, since the 16550A is capable of handling a top speed of 1.5
> > + * megabits/second; but this requires the faster clock.
> > + */
> > +#define BASE_BAUD (1843200 / 16)
> > +
> > +#endif /* _ASM_SERIAL_H */
>
> Acked-by: Alan Cox <alan@redhat.com>
Not sure if that assumption is correct since I haven't heard of anyone
creating an avr32 board with a 16550A UART on it...
But I'm not going to be difficult about it. Applied this one and four
of the others:
Applying add include/asm-avr32/xor.h
Applying avr32: don't offer CONFIG_RTC
Applying avr32: don't offer CONFIG_GEN_RTC
Applying avr32: don't offer PARPORT_PC
Applying avr32: add include/asm-avr32/serial.h
I skipped the IDE one since Bart took it.
Thanks a lot!
Haavard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-04-16 5:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-14 14:17 [2.6 patch] avr32: don't offer SERIAL_8250 Adrian Bunk
2008-04-14 14:36 ` Alan Cox
2008-04-14 18:42 ` [2.6 patch] avr32: add include/asm-avr32/serial.h Adrian Bunk
2008-04-14 21:56 ` Alan Cox
2008-04-16 5:53 ` Haavard Skinnemoen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).