From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH v2] serial: 8250: fix shared interrupts issues with SMP and RT kernels Date: Wed, 9 Jul 2008 20:21:31 +0100 Message-ID: <20080709202131.362943ea@the-village.bc.nu> References: <20080623232957.GA5111@polina.dev.rtsoft.ru> <20080624001221.GA20685@elte.hu> <20080701134343.GA1865@polina.dev.rtsoft.ru> <20080701144353.7285805d@lxorguk.ukuu.org.uk> <20080701150254.GA13390@polina.dev.rtsoft.ru> <20080709192943.GA12278@polina.dev.rtsoft.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:55282 "EHLO the-village.bc.nu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751227AbYGIT5W (ORCPT ); Wed, 9 Jul 2008 15:57:22 -0400 In-Reply-To: <20080709192943.GA12278@polina.dev.rtsoft.ru> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: avorontsov@ru.mvista.com Cc: Ingo Molnar , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Steven Rostedt , Daniel Walker > > But this can't happen here. IRQ will not grab the up->port.lock, > > because port isn't registered in the 8250 IRQ handling chain (yet). > > Alan, are there any issues with the proof or the patch itself? The logic looks fine, the analysis looks fine. Alan