Re: [PATCH] Fix oops in the 8250 serial driver when accessing a removed device

[Laurent Pinchart <laurentp@cse-semaphore.com>]

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

Hi Russell,

On Tuesday 22 July 2008, Alan Cox wrote:
> > When a plug-and-play 8250 device is detected, the driver reuses one of the
> > dummy ports. If that device is later removed, the port goes pack to the
> > dummy ports pool. The capabilities field is not reset, which causes a oops
> > when trying to access the port.
> 
> Some day we need to allocate new dummy ports so there is always one free.
> 
> > This patch resets the capabilities field when a 8250 device is
> > unregistered. 
> 
> Looks good to me. Would appreciate Russell's view though.

Could you please review the patch (available at http://marc.info/?l=linux-serial&m=121674107306179&w=2) ? I'd like it to go into 2.6.27 if possible.

Best regards,

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]