public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Laurent Pinchart <laurentp@cse-semaphore.com>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH/RFC] 8250: Auto RS485 direction control
Date: Thu, 24 Jul 2008 13:52:11 +0100	[thread overview]
Message-ID: <20080724125210.GD9327@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20080724132746.1a961584@lxorguk.ukuu.org.uk>

On Thu, Jul 24, 2008 at 01:27:46PM +0100, Alan Cox wrote:
> > On devices which don't support hardware RS485, what should be done is
> > the termios bit remains clear, so that programs can tell if the port
> > doesn't support it (as per POSIX.)
> 
> Or the serial layer should do it in software.
> 
> > I would also stress that this feature should be limited to enabling
> > _hardware_ RS485 support, and not software emulation of that.  The
> > reason being is that with plain 16550 UARTs, the best you can do 
> > with interrupts is to know when the last character is transferred out
> > of the transmit holding register into the transmit shift register - in
> > other words, before the last character has finished transmission.
> 
> So the 16550 sucks, that's not true of everyone elses uarts.

It's true of all 8250 compatibles which don't have hardware RS485
support.  I think that's all of them except 16850 and 16960.

> > Basically, software RS485 is very yucky, and we've always resisted
> > having that support in the kernel.
> 
> Agreed entirely. Which takes us more and more to the setserial path even
> if it means standardising some setserial bit to get everyone back in line.

I don't have a problem with that, except one question: CRTSCTS.

A while back, there were people asking for:
1. handshaking on DTR/DSR rather than RTS/CTS.
2. a different handshaking method for RTS/CTS (where you assert
   RTS to ask for permission to send when you actually have something
   to send.)

Should CRTSCTS be a global "enable some kind of flow control" bit and
setserial be used to configure the actual flow control method
(conventional RTS/CTS, DTR/DSR, alternate RTS/CTS, RS485 on RTS,
RS485 on DTR) ?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

  reply	other threads:[~2008-07-24 12:52 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24 11:47 [PATCH/RFC] 8250: Auto RS485 direction control Laurent Pinchart
2008-07-24 11:57 ` Alan Cox
2008-07-24 12:24   ` Russell King
2008-07-24 12:27     ` Alan Cox
2008-07-24 12:52       ` Russell King [this message]
2008-07-24 13:00         ` Alan Cox
2008-07-24 13:18         ` Laurent Pinchart
2008-07-24 14:13         ` Matt Schulte
2008-07-24 14:47           ` Russell King
2008-07-24 12:10 ` Russell King
2008-08-04 14:14 ` Tosoni
2008-08-04 14:22   ` Grant Edwards
2008-08-04 14:36   ` Laurent Pinchart
2008-08-04 16:15     ` Grant Edwards
2008-08-04 16:21       ` Grant Edwards
2008-08-05  9:41       ` Laurent Pinchart
2008-08-05 12:55         ` Tosoni
2008-08-06 14:30           ` Christopher Gibson
2008-08-06 16:33             ` Tosoni
2008-08-09 10:08               ` Christopher Gibson
2008-08-07  8:50             ` Laurent Pinchart
2008-08-07 13:50               ` Grant Edwards
2008-08-10  3:49               ` Christopher Gibson
2008-08-10  3:57               ` Christopher Gibson
2008-08-29 12:22                 ` Christopher Gibson
2008-12-02 13:09                 ` [PATCH/RFC] " Christopher Gibson
2008-12-04 11:14                   ` Christopher Gibson
2008-08-04 16:47     ` [PATCH/RFC] 8250: " Tosoni
2008-08-04 17:46       ` Grant Edwards
2008-08-04 20:59         ` Matt Schulte
2008-08-05  9:23         ` Laurent Pinchart
2008-08-05  9:34         ` Tosoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080724125210.GD9327@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=laurentp@cse-semaphore.com \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox