Re: [PATCH/RFC] 8250: Auto RS485 direction control

Alan Cox
2008-07-24T12:14:39Z

On Thu, 24 Jul 2008 13:47:29 +0200
Laurent Pinchart <laurentp@cse-semaphore.com> wrote:

> This patch adds support for the automatic RS485 direction control feature
> present in 16850 UARTs.
>
> A new termios c_cflag, CARTS, is introduced to configure automatic direction
> control from userspace.
>
> This is a first proposal. I'm open to suggestions regarding the CARTS name.
> I assume the CARTS flag will have to be added to all asm/termbits.h headers.
> Why are the termios bits definitions platform specific ?

Because many of them are made to match up with the existing previous
OS on those systems (eg to match with Alpha OSF).

I've no fundamental objection to this but I do wonder whether this
feature belongs in setserial rather than termios as it is so chip
specific ?

Alan