Re: [PATCH/RFC] 8250: Auto RS485 direction control

Laurent Pinchart
2008-08-04T14:37:07Z

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

On Monday 04 August 2008, Tosoni wrote:
> About the flags names -- CARTS, UART_FCTR_RS485
>
> May I suggest CRTSTOGGLE since it is known by that kind of name in other
> OS's :-)

I like Russell's proposal of sticking to CRTSCTS and adding options to setserial:

> Should CRTSCTS be a global "enable some kind of flow control" bit and
> setserial be used to configure the actual flow control method
> (conventional RTS/CTS, DTR/DSR, alternate RTS/CTS, RS485 on RTS,
> RS485 on DTR) ?

Any opinion on that ?

> And further, it says was RTS will do, instead of why. Maybe someone could
> use it for something other than RS485 ?

I agree with you here. The name should reflect that RTS is used in 'envelope' mode (asserted during data transmission, idle between frames).

Best regards,

--
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]