public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] serial_core: fix printk format warnings
@ 2008-09-21  1:11 Alexander Beregalov
  2008-09-21  1:15 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Beregalov @ 2008-09-21  1:11 UTC (permalink / raw)
  To: linux-kernel, linux-serial, alan

drivers/serial/serial_core.c:2158: warning: format '%x' expects type
'unsigned int', but argument 4 has type 'long unsigned int'
drivers/serial/serial_core.c:2162: warning: format '%x' expects type
'unsigned int', but argument 4 has type 'long unsigned int

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---

 drivers/serial/serial_core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
index effd0bd..d531ae9 100644
--- a/drivers/serial/serial_core.c
+++ b/drivers/serial/serial_core.c
@@ -2155,11 +2155,11 @@ uart_report_port(struct uart_driver *drv, struct uart_port *port)
 	switch (port->iotype) {
 	case UPIO_PORT:
 		snprintf(address, sizeof(address),
-			 "I/O 0x%x", port->iobase);
+			 "I/O 0x%lx", port->iobase);
 		break;
 	case UPIO_HUB6:
 		snprintf(address, sizeof(address),
-			 "I/O 0x%x offset 0x%x", port->iobase, port->hub6);
+			 "I/O 0x%lx offset 0x%x", port->iobase, port->hub6);
 		break;
 	case UPIO_MEM:
 	case UPIO_MEM32:

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] serial_core: fix printk format warnings
  2008-09-21  1:11 [PATCH] serial_core: fix printk format warnings Alexander Beregalov
@ 2008-09-21  1:15 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-09-21  1:15 UTC (permalink / raw)
  To: a.beregalov; +Cc: linux-kernel, linux-serial, alan, akpm

From: Alexander Beregalov <a.beregalov@gmail.com>
Date: Sun, 21 Sep 2008 05:11:31 +0400

> drivers/serial/serial_core.c:2158: warning: format '%x' expects type
> 'unsigned int', but argument 4 has type 'long unsigned int'
> drivers/serial/serial_core.c:2162: warning: format '%x' expects type
> 'unsigned int', but argument 4 has type 'long unsigned int
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>

This is because of a patch of mine that Andrew added to -mm,
which changed the ioport to be an unsigned long.

I have some updates which I'll send to Andrew which should
cure this.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-21  1:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-21  1:11 [PATCH] serial_core: fix printk format warnings Alexander Beregalov
2008-09-21  1:15 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox