From: David Miller <davem@davemloft.net>
To: jwboyer@gmail.com
Cc: alan@redhat.com, torvalds@osdl.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 22/27] serial: Make uart_port's ioport "unsigned long".
Date: Fri, 10 Oct 2008 09:19:25 -0700 (PDT) [thread overview]
Message-ID: <20081010.091925.120612769.davem@davemloft.net> (raw)
In-Reply-To: <20081010125434.GB8590@yoda.jdub.homelinux.org>
From: Josh Boyer <jwboyer@gmail.com>
Date: Fri, 10 Oct 2008 08:54:34 -0400
> On Fri, Oct 10, 2008 at 11:50:56AM +0100, Alan Cox wrote:
> >From: David Miller <davem@davemloft.net>
> >
> >Otherwise the top 32-bits of the resource value get chopped
> >off on 64-bit systems, and the resulting I/O accesses go to
> >random places.
> >
> >Thanks to testing and debugging by Josip Rodin, which helped
> >track this down.
> >
> >Signed-off-by: David S. Miller <davem@davemloft.net>
> >Signed-off-by: Alan Cox <alan@redhat.com>
>
> I emailed on an earlier posting of this about using resource_size_t
> instead as we have 32-bit CPUs with 64-bit address spaces. If I'm
> totally wrong, that's fine but I'm still wondering if that would be
> a better general solution.
That seems like a fine idea to me, please post a follow-on patch
if you like :-)
next prev parent reply other threads:[~2008-10-10 16:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 10:36 [PATCH 00/27] First block of the tty backlog Alan Cox
2008-10-10 10:36 ` [PATCH 01/27] drivers/serial/crisv10.c: add missing put_tty_driver Alan Cox
2008-10-10 10:36 ` [PATCH 02/27] drivers/char/hvc_console.c: adjust call to put_tty_driver Alan Cox
2008-10-10 10:36 ` [PATCH 03/27] coldfire: scheduled SERIAL_COLDFIRE removal Alan Cox
2008-10-10 10:37 ` [PATCH 04/27] epca: call tty_port_init Alan Cox
2008-10-10 10:48 ` [PATCH 05/27] Blackfin Serial Driver: use __initdata for data, not __init Alan Cox
2008-10-10 10:48 ` [PATCH 06/27] Blackfin Serial Driver: Fix bug - should suspend/resume/remove all uart ports Alan Cox
2008-10-10 10:48 ` [PATCH 07/27] Blackfin Serial Driver: trim trailing whitespace -- no functional changes Alan Cox
2008-10-10 10:48 ` [PATCH 08/27] Blackfin Serial Driver: move common variables out of serial headers and into the serial driver Alan Cox
2008-10-10 10:48 ` [PATCH 09/27] Blackfin Serial Driver: Remove useless stop Alan Cox
2008-10-10 10:49 ` [PATCH 10/27] Blackfin Serial Driver: Fix bug - Don't call tx_stop in tx_transfer Alan Cox
2008-10-10 10:49 ` [PATCH 11/27] Blackfin Serial Driver: Fix bug - ircp fails on sir over Blackfin UART Alan Cox
2008-10-10 10:49 ` [PATCH 12/27] Blackfin Serial Driver: Fix bug - request UART2/3 peripheral mapped interrupts in PIO mode Alan Cox
2008-10-10 10:49 ` [PATCH 13/27] Fix oti6858 debug level Alan Cox
2008-10-10 10:49 ` [PATCH 14/27] Char: cyclades. remove bogus iomap Alan Cox
2008-10-10 10:49 ` [PATCH 15/27] Char: sx, fix io unmapping Alan Cox
2008-10-10 10:50 ` [PATCH 16/27] Char: merge ip2main and ip2base Alan Cox
2008-10-10 10:50 ` [PATCH 17/27] ip2, cleanup globals Alan Cox
2008-10-10 10:50 ` [PATCH 18/27] ip2, fix sparse warnings Alan Cox
2008-10-10 10:50 ` [PATCH 19/27] ip2, init/deinit cleanup Alan Cox
2008-10-10 10:50 ` [PATCH 20/27] ip2: avoid add_timer with pending timer Alan Cox
2008-10-10 10:50 ` [PATCH 21/27] audit: Handle embedded NUL in TTY input auditing Alan Cox
2008-10-10 10:50 ` [PATCH 22/27] serial: Make uart_port's ioport "unsigned long" Alan Cox
2008-10-10 12:54 ` Josh Boyer
2008-10-10 16:19 ` David Miller [this message]
2008-10-10 10:51 ` [PATCH 23/27] nozomi: Fix close on error Alan Cox
2008-10-10 10:51 ` [PATCH 24/27] serial-make-uart_ports-ioport-unsigned-long-fix Alan Cox
2008-10-10 10:51 ` [PATCH 25/27] usb: fix pl2303 initialization Alan Cox
2008-10-10 10:51 ` [PATCH 26/27] ftdi: A few errors are err() that should be debug which causes much spewage Alan Cox
2008-10-10 10:52 ` [PATCH 27/27] serial_8250: pci_enable_device fail is not fully handled Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010.091925.120612769.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alan@redhat.com \
--cc=jwboyer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox