From: Andrew Morton <akpm@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial/8250: fix uninitialized warnings
Date: Mon, 10 Nov 2008 15:58:08 -0800 [thread overview]
Message-ID: <20081110155808.a4d94ee7.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081110234843.0fba9f16@lxorguk.ukuu.org.uk>
On Mon, 10 Nov 2008 23:48:43 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > That's a regression in current gcc, surely?
>
> Oh and as a PS: Gcc is I believe right because if the loop is run zero
> times then pos = NULL (ie n == NULL so the first BUG_ON fires)
Whoa. That would be clever of it.
On about half the architectures, BUG is not considered to be no-return.
Dunno if that's a gcc shortcoming or if the architectures just haven't
implemented it properly yet. This causes those architectures to
generate quite a few warnings in generic code which don't appear on
x86 (this would be one such case if your above theory is correct).
This is fairly irritating of those architectures, as I keep on going
in asking "what's up" and deciding "oh, that again".
next prev parent reply other threads:[~2008-11-10 23:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 17:26 [PATCH] serial/8250: fix uninitialized warnings KOSAKI Motohiro
2008-11-04 17:41 ` Alan Cox
2008-11-05 4:51 ` KOSAKI Motohiro
2008-11-10 22:30 ` Andrew Morton
2008-11-10 23:47 ` Alan Cox
2008-11-10 23:48 ` Alan Cox
2008-11-10 23:58 ` Andrew Morton [this message]
2008-11-11 0:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081110155808.a4d94ee7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox