From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial/8250: fix uninitialized warnings
Date: Mon, 10 Nov 2008 23:47:44 +0000 [thread overview]
Message-ID: <20081110234744.0eb062b5@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20081110143039.6f21fdc3.akpm@linux-foundation.org>
> hlist_for_each() can execute that loop zero times, in which case
> serial_unlink_irq_chain will dereference an uninitialised variable.
>
> Presumably the list shouldn't be empty at this stage, but this
> is not particularly robust behaviour if that should happen..
And the only cases that can trip are the more important BUG_ON() checks.
You could remove the BUG_ON() calls and make it less robust but that
seems slightly well silly to me ?
Alan
next prev parent reply other threads:[~2008-11-10 23:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 17:26 [PATCH] serial/8250: fix uninitialized warnings KOSAKI Motohiro
2008-11-04 17:41 ` Alan Cox
2008-11-05 4:51 ` KOSAKI Motohiro
2008-11-10 22:30 ` Andrew Morton
2008-11-10 23:47 ` Alan Cox [this message]
2008-11-10 23:48 ` Alan Cox
2008-11-10 23:58 ` Andrew Morton
2008-11-11 0:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081110234744.0eb062b5@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox