From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-mips@linux-mips.org, linux-serial@vger.kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
David Daney <ddaney@caviumnetworks.com>,
Tomaso Paoletti <tpaoletti@caviumnetworks.com>
Subject: Re: [PATCH 23/26] Serial: UART driver changes for Cavium OCTEON.
Date: Thu, 20 Nov 2008 20:06:30 +0000 [thread overview]
Message-ID: <20081120200630.33111a2f@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1227047057-4911-5-git-send-email-ddaney@caviumnetworks.com>
> + if ((up->bugs & UART_BUG_OCTEON_IIR) && (iir & 0xf) == 7) {
> + /* Busy interrupt */
> + serial_in(up, UART_OCTEON_USR);
> + iir = serial_in(up, UART_IIR);
> + }
Could this not be hidden in the register read method for the octeon and
thus kept out of core code ?
prev parent reply other threads:[~2008-11-20 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 22:21 [PATCH 00/26] Add Cavium OCTEON processor support (v4) David Daney
2008-11-18 22:24 ` [PATCH 19/26] 8250: Don't clobber spinlocks David Daney
2008-11-18 22:24 ` [PATCH 20/26] 8250: Serial driver changes to support future Cavium OCTEON serial patches David Daney
2008-11-20 20:02 ` Alan Cox
2008-11-18 22:24 ` [PATCH 21/26] Serial: Allow port type to be specified when calling serial8250_register_port David Daney
[not found] ` <20081120200256.73f98e09@lxorguk.ukuu.org.uk>
2008-11-20 21:00 ` David Daney
2008-11-18 22:24 ` [PATCH 22/26] 8250: Allow port type to specify bugs that are not probed for David Daney
2008-11-18 22:24 ` [PATCH 23/26] Serial: UART driver changes for Cavium OCTEON David Daney
2008-11-20 20:06 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120200630.33111a2f@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=tpaoletti@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox