From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] Add support for the nwp serial device Date: Fri, 21 Nov 2008 13:22:44 -0800 Message-ID: <20081121132244.e9e9fd74.akpm@linux-foundation.org> References: <200811201501.24000.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:51055 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005AbYKUVW5 (ORCPT ); Fri, 21 Nov 2008 16:22:57 -0500 In-Reply-To: <200811201501.24000.arnd@arndb.de> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Arnd Bergmann Cc: linux-serial@vger.kernel.org, ben@codiert.org, linuxppc-dev@ozlabs.org On Thu, 20 Nov 2008 15:01:23 +0100 Arnd Bergmann wrote: > This patch adds support for the nwp serial device which is connected to > a DCR bus. It uses the of_serial device driver to determine necessary > properties from the device tree. The supported device is added as serial > port number 84. checkpatch has a decent whine over this. Some of those things you might decide to ignore, other things tell me that you never ran it anyway... I'd suggest that nwpserial_pops and nwpserial_reg be marked const, as they don't need to be in read/write storage. Except that doesn't work because the kernel isn't very const-competent. Ho hum. (does a powerpc allmodconfig) drivers/serial/nwpserial.c:443: warning: data definition has no type or storage class drivers/serial/nwpserial.c:443: warning: type defaults to 'int' in declaration of 'console_initcall' drivers/serial/nwpserial.c:443: warning: parameter names (without types) in function declaration drivers/serial/nwpserial.c:400: warning: 'nwpserial_console_init' defined but not used The file fails to include linux/init.h. It should do so, but that doesn't fix the above. Apparently it hasn't been tested as a kernel module...