From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Sheng Yang <sheng@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] 8250: Eliminate compile warning of 8250.c
Date: Tue, 25 Nov 2008 10:43:34 +0000 [thread overview]
Message-ID: <20081125104334.351e94ee@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200811251831.34737.sheng@linux.intel.com>
> Can't understand initializing got "risk hiding future ones". As I know, didn't
Because if you set it to NULL and later delete a line which does the
intended assignment you will no longer get a warning.
> think BUG_ON(n==null) cover this. And I don't think leave it to compiler is
> more proper here.
The BUG_ON covers it, the current gcc gets this right and works it out.
NAK again
next prev parent reply other threads:[~2008-11-25 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 3:55 [PATCH] 8250: Eliminate compile warning of 8250.c Sheng Yang
2008-11-25 3:58 ` Sheng Yang
2008-11-25 10:22 ` Alan Cox
2008-11-25 10:31 ` Sheng Yang
2008-11-25 10:43 ` Alan Cox [this message]
2008-11-25 10:51 ` Sheng Yang
2008-11-25 11:12 ` Olivier Galibert
2008-11-25 11:13 ` Alan Cox
2008-11-25 11:32 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125104334.351e94ee@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox