From: Olivier Galibert <galibert@pobox.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] 8250: Eliminate compile warning of 8250.c
Date: Tue, 25 Nov 2008 12:12:13 +0100 [thread overview]
Message-ID: <20081125111213.GA6698@dspnet.fr.eu.org> (raw)
In-Reply-To: <200811251851.44768.sheng@linux.intel.com>
On Tue, Nov 25, 2008 at 06:51:44PM +0800, Sheng Yang wrote:
> The logic here is strange...
>
> If you used old compiler, you would get a warning, and you thought that's
> ensured we won't delete a intended assignment by mistake.
>
> If you used new compiler, you wouldn't get a warning, and you think this time
> the compiler get it right.
The new compiler gets it right. If you delete the assignment with the
new compiler, *then* you get a warning.
> OK. if you worry about "delete a line which does the intended assignment", the
> updated version with BUG_ON(i == NULL) can help.
Compile-time error detection is better than runtime.
OG.
next prev parent reply other threads:[~2008-11-25 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 3:55 [PATCH] 8250: Eliminate compile warning of 8250.c Sheng Yang
2008-11-25 3:58 ` Sheng Yang
2008-11-25 10:22 ` Alan Cox
2008-11-25 10:31 ` Sheng Yang
2008-11-25 10:43 ` Alan Cox
2008-11-25 10:51 ` Sheng Yang
2008-11-25 11:12 ` Olivier Galibert [this message]
2008-11-25 11:13 ` Alan Cox
2008-11-25 11:32 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125111213.GA6698@dspnet.fr.eu.org \
--to=galibert@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox