Re: [PATCH 09/75] Per-mount allocated_ptys

Michał Mirosław
2009-01-02T19:53:46Z

On Fri, Jan 02, 2009 at 01:41:21PM +0000, Alan Cox wrote:
> To enable multiple mounts of devpts, 'allocated_ptys' must be a per-mount
> variable rather than a global variable. Move 'allocated_ptys' into the
> super_block's s_fs_info.
[...]
> extern int pty_limit; /* Config limit on Unix98 ptys */
> -static DEFINE_IDA(allocated_ptys);
> static DEFINE_MUTEX(allocated_ptys_lock);
>
> static struct vfsmount *devpts_mnt;
> @@ -55,6 +54,15 @@ static const match_table_t tokens = {
> {Opt_err, NULL}
> };
>
> +struct pts_fs_info {
> + struct ida allocated_ptys;
> +};
[...]

Shouldn't allocated_ptys_lock be included with allocated_ptys in
pts_fs_info? This probably doesn't matter unless machine is doing
a lot of PTY creation/removal, but is more correct IMO.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html