Re: [PATCH 72/75] tty: Fix an ircomm warning and note another bug

Wolfram Sang
2009-01-05T17:42:47Z

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

Hello Alan,

On Fri, Jan 02, 2009 at 01:50:20PM +0000, Alan Cox wrote:

> From: Alan Cox <alan@redhat.com>
>
> Roel Kluin noted that line is unsigned so one test is unneccessary. Also
> add a warning for another flaw I noticed while making this change.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
> ---
>
> net/irda/ircomm/ircomm_tty.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>
> diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c
> index e4e2cae..086d5ef 100644
> --- a/net/irda/ircomm/ircomm_tty.c
> +++ b/net/irda/ircomm/ircomm_tty.c
> @@ -371,9 +371,8 @@ static int ircomm_tty_open(struct tty_struct *tty, struct file *filp)
> IRDA_DEBUG(2, "%s()\n", __func__ );
>
> line = tty->index;
> - if ((line < 0) || (line >= IRCOMM_TTY_PORTS)) {
> + if (line >= IRCOMM_TTY_PORTS)
> return -ENODEV;
> - }
>
> /* Check if instance already exists */
> self = hashbin_lock_find(ircomm_tty, line, NULL);
> @@ -405,6 +404,8 @@ static int ircomm_tty_open(struct tty_struct *tty, struct file *filp)
> * Force TTY into raw mode by default which is usually what
> * we want for IrCOMM and IrLPT. This way applications will
> * not have to twiddle with printcap etc.
> + *
> + * Note this is completely usafe and doesn't work properly

Do you mean "unsafe"?

> */
> tty->termios->c_iflag = 0;
> tty->termios->c_oflag = 0;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Kind regards,

Wolfram

--
Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]