From: Matthias Fuchs <mfuchs@ma-fu.de>
To: Christopher Gibson <chris@toftronix.com.au>
Cc: linux-serial@vger.kernel.org,
Laurent Pinchart <laurentp@cse-semaphore.com>
Subject: Re: [PATCH V2] serial: Add ioctl to enable auto rs485 mode with some Exar UARTs
Date: Wed, 7 Jan 2009 22:56:03 +0100 [thread overview]
Message-ID: <200901072256.03667.mfuchs@ma-fu.de> (raw)
In-Reply-To: <1231336690.29906.48.camel@thetriton.toftronix.com.au>
> On Fri, 2009-01-02 at 17:26 +0100, Matthias Fuchs wrote:
> > Some Exar UARTs support a auto rs485 mode. In this mode
> > the UART's RTS# pin is activated during transmitting and
> > can be used to enable a rs485 line driver.
> --->8----
>
> > +
> > + case TIOCGRS485:
> > + {
> > + struct serial_rs485 rs485ctrl;
>
> Should the TIOCGRS485 call set delay_rts_before_send structure element
> to 0 to demonstrate that there is no delay ability? memset(&rs485ctrl,
> 0, sizeof(struct serial_rs485)); missing?
Yes, that makes sense. I will add the memset and also add the saving of the LCR
as Laurent requested.
Matthias
prev parent reply other threads:[~2009-01-07 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-02 16:26 [PATCH V2] serial: Add ioctl to enable auto rs485 mode with some Exar UARTs Matthias Fuchs
2009-01-07 10:35 ` Laurent Pinchart
2009-01-07 13:58 ` Christopher Gibson
2009-01-07 21:56 ` Matthias Fuchs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901072256.03667.mfuchs@ma-fu.de \
--to=mfuchs@ma-fu.de \
--cc=chris@toftronix.com.au \
--cc=laurentp@cse-semaphore.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox