From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Jonker M.D.S.X." <nlv14114@e3.nl-htc01.nxp.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
m.d.s.x.jonker@gmail.com
Subject: Re: [PATCH] serial: pnx8xxx_uart: Fix break signal handling
Date: Tue, 13 Jan 2009 12:11:35 +0000 [thread overview]
Message-ID: <20090113121135.5565b302@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200901131109.n0DB9DRJ010712@pc67243907.ddns.nl-htc01.nxp.com>
On Tue, 13 Jan 2009 12:09:13 +0100
"Jonker M.D.S.X." <nlv14114@e3.nl-htc01.nxp.com> wrote:
> From: Mischa Jonker <mischa.jonker@nxp.com>
>
> When a break signal is detected, the next character should be ignored.
> This was not implemented correctly for the pnx8xxx_uart driver.
>
> Signed-off-by: Mischa Jonker <mischa.jonker@nxp.com>
> ---
>
> diff --git a/drivers/serial/pnx8xxx_uart.c b/drivers/serial/pnx8xxx_uart.c
> index 22e30d2..1bb8f1b 100644
> --- a/drivers/serial/pnx8xxx_uart.c
> +++ b/drivers/serial/pnx8xxx_uart.c
> @@ -187,7 +187,7 @@ static void pnx8xxx_rx_chars(struct pnx8xxx_port *sport)
> status = FIFO_TO_SM(serial_in(sport, PNX8XXX_FIFO)) |
> ISTAT_TO_SM(serial_in(sport, PNX8XXX_ISTAT));
> while (status & FIFO_TO_SM(PNX8XXX_UART_FIFO_RXFIFO)) {
> - ch = serial_in(sport, PNX8XXX_FIFO);
> + ch = serial_in(sport, PNX8XXX_FIFO) & 0xff;
This appears to be unrelated.
next prev parent reply other threads:[~2009-01-13 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 11:09 [PATCH] serial: pnx8xxx_uart: Fix break signal handling Jonker M.D.S.X.
2009-01-13 12:11 ` Alan Cox [this message]
2009-01-13 13:22 ` Mischa Jonker
2009-01-13 13:48 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113121135.5565b302@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.d.s.x.jonker@gmail.com \
--cc=nlv14114@e3.nl-htc01.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox