From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mischa Jonker <m.d.s.x.jonker@gmail.com>
Cc: "Jonker M.D.S.X." <nlv14114@e3.nl-htc01.nxp.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: pnx8xxx_uart: Fix break signal handling
Date: Tue, 13 Jan 2009 13:48:12 +0000 [thread overview]
Message-ID: <20090113134812.0ff43e4e@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4142f31c0901130522n5273fb67j41cf1aaf7b32853c@mail.gmail.com>
> > This appears to be unrelated.
> >
>
> Correct, you can look to it as two separate bugs:
> a) the next character is not ignored while it should;
> b) the status bits 31-8 are copied to the 'ch' variable while they shouldn't.
>
> Both bugs prevent correct break signal handling (and therefore correct
> behaviour of the magic SysRq key). Bug b didn't cause too much trouble
> earlier because in most situations the status bits are all zero; for
> this case they unfortunately aren't.
Ok that makes sense - no need to split them.
prev parent reply other threads:[~2009-01-13 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 11:09 [PATCH] serial: pnx8xxx_uart: Fix break signal handling Jonker M.D.S.X.
2009-01-13 12:11 ` Alan Cox
2009-01-13 13:22 ` Mischa Jonker
2009-01-13 13:48 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113134812.0ff43e4e@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.d.s.x.jonker@gmail.com \
--cc=nlv14114@e3.nl-htc01.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox