From: Laurent Pinchart <laurentp@cse-semaphore.com>
To: Krzysztof Gantzke <k.gantzke@meilhaus.de>
Cc: linux-serial@vger.kernel.org
Subject: Re: Support for Meilhaus serial boards - patch (kernel 2.6.28)
Date: Tue, 20 Jan 2009 14:22:57 +0100 [thread overview]
Message-ID: <200901201423.00936.laurentp@cse-semaphore.com> (raw)
In-Reply-To: <497497E8.3050206@meilhaus.de>
[-- Attachment #1: Type: text/plain, Size: 820 bytes --]
On Monday 19 January 2009 16:10:32 Krzysztof Gantzke wrote:
> Dear Linux-serial team
> Meilhaus (PCI ID: 0x1402) ME90xx, ME91xx and ME93xx support added.
> The are RS232 and RS422/485 PCI serial boards.
> This patch was tested on x86 and x86_64 machines.
>
> Could you added this to main tree, please.
NAK. You should not add an ioctl to revert to RS232 mode but check
serial_rs485.flags in TIOCSRS485. Enable RS485 when SER_RS485_ENABLED is set,
disable it otherwise.
You should also probably base your patch to 8250.c on top of Matthias Fuchs'
patch ('[PATCH V3] serial: Add ioctl to enable auto rs485 mode with some Exar
UARTs').
Best regards,
--
Laurent Pinchart
CSE Semaphore Belgium
Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium
T +32 (2) 387 42 59
F +32 (2) 387 42 75
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-01-20 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 15:10 Support for Meilhaus serial boards - patch (kernel 2.6.28) Krzysztof Gantzke
2009-01-20 13:22 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901201423.00936.laurentp@cse-semaphore.com \
--to=laurentp@cse-semaphore.com \
--cc=k.gantzke@meilhaus.de \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox