From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Deepak Saxena <dsaxena@plexity.net>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 8250: Don't restore NS16550 mode when console suspend is disabled
Date: Wed, 13 May 2009 01:18:42 +0100 [thread overview]
Message-ID: <20090513011842.22d9cd6c@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.01.0905121452190.3343@localhost.localdomain>
> Hmm. I already applied this, but then after looking closer, I undid that.
> Why? It looks buggy:
I'm a bit suprised that as tty and serial maintainer this is the first
time I see the patch.
> Isn't that second test wrong? Should it not be
>
> if ((up->capabilities & UART_NATSEMI) &&
> (console_suspend_enabled || !uart_console(&up->port)) {
>
> instead?
The patch seems totally bogus anyway. If the console was in a high speed
mode it should be resumed in a high speed mode. What are the actual
details here.
Surely if my console is at 230Kbits/sec then resuming it at a totally
different speed is going to break things for people even if it happens to
help XO debug ?
next prev parent reply other threads:[~2009-05-13 0:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 21:00 [PATCH] 8250: Don't restore NS16550 mode when console suspend is disabled Deepak Saxena
2009-05-12 22:00 ` Linus Torvalds
2009-05-13 0:18 ` Alan Cox [this message]
2009-05-13 0:28 ` Deepak Saxena
2009-05-13 8:44 ` Alan Cox
2009-05-13 14:58 ` Linus Torvalds
2009-05-13 15:35 ` Alan Cox
2009-05-13 18:04 ` Deepak Saxena
2009-05-13 18:46 ` Alan Cox
2009-05-18 18:24 ` Deepak Saxena
2009-05-18 19:07 ` Alan Cox
2009-05-13 1:01 ` Joe Perches
2009-05-13 0:34 ` Deepak Saxena
2009-05-12 22:08 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090513011842.22d9cd6c@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox