On May 13 2009, at 16:35, Alan Cox was caught saying: > Deepak's original patch from 2008 is actually much better. He puts the > chip back in the right hardware configuration for the speed. He doesn't > randomly regress other platforms and configurations and he does it by > calling the standard methods in the driver to do the job. > > http://dev.laptop.org/~dsaxena/patches/console_suspend_old.patch > > It also has another advantage - it fixes the behaviour for almost > everything in drivers/serial not just a specific uart. Technically he > should take tty->termios_mutex before state->mutex in that code path as > the upstream code has changed but in every other respect its the proper > solution. I thought the fact that we were touching a core driver to fix what seemed like an XO issue was too intrusive. > So can we apply Deepak's original correct 2008 patch instead please ? I've updated it with proper header and attached. ~Deepak