linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: alsa-devel@alsa-project.org, Jonathan McDowell <noodles@earth.li>,
	Tony Lindgren <tony@atomide.com>,
	Peter Ujfalusi <peter.ujfalusi@nokia.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	e3-hacking@earth.li, Arun KS <arunks@mistralsolutions.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [RFC] [PATCH 1/3] ASoC: Add support for Conexant CX20442-11 voice modem codec
Date: Tue, 28 Jul 2009 16:07:27 +0100	[thread overview]
Message-ID: <20090728150727.GA10870@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <200907281659.36000.jkrzyszt@tis.icnet.pl>

On Tue, Jul 28, 2009 at 04:59:33PM +0200, Janusz Krzysztofik wrote:

> Following that model, the line discipline code didn't seam to belong to a 
> codec driver for me. If it could be recognized as a new bus dirver, it should 
> be pushed down probably into a separate module. However, if it was rather 
> some kind of a bus adapter driver, it seamed to belong to the machine code.

The way it looks with the current code the line discipline itself is
going to apply equally well to any serial port that's used - I'm not
clear what's system-specific about it.  The bit that connects the line
discipline to the line is a different matter but the bit that interacts
with the TTY layer after registration is working through a pluggable
abstraction layer and shouldn't, I'd expect, be specific to the
particular serial port.

  reply	other threads:[~2009-07-28 15:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22  3:22 [RFC] [PATCH 1/3] ASoC: Add support for Conexant CX20442-11 voice modem codec Janusz Krzysztofik
2009-07-22 10:10 ` Mark Brown
2009-07-22 14:01   ` Janusz Krzysztofik
2009-07-28 14:59   ` [alsa-devel] " Janusz Krzysztofik
2009-07-28 15:07     ` Mark Brown [this message]
2009-07-28 16:07       ` Janusz Krzysztofik
2009-07-28 16:11         ` [alsa-devel] " Mark Brown
2009-07-28 16:36           ` Janusz Krzysztofik
2009-07-28 16:39             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090728150727.GA10870@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=arunks@mistralsolutions.com \
    --cc=e3-hacking@earth.li \
    --cc=jkrzyszt@tis.icnet.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=noodles@earth.li \
    --cc=peter.ujfalusi@nokia.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).