From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [RFC] [PATCH 1/3] ASoC: Add support for Conexant CX20442-11 voice modem codec Date: Tue, 28 Jul 2009 17:39:02 +0100 Message-ID: <20090728163902.GA26657@rakim.wolfsonmicro.main> References: <200907220522.29221.jkrzyszt@tis.icnet.pl> <200907281807.31070.jkrzyszt@tis.icnet.pl> <20090728161131.GA22349@rakim.wolfsonmicro.main> <200907281836.03049.jkrzyszt@tis.icnet.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <200907281836.03049.jkrzyszt@tis.icnet.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Janusz Krzysztofik Cc: alsa-devel@alsa-project.org, Jonathan McDowell , Tony Lindgren , Peter Ujfalusi , "linux-kernel@vger.kernel.org" , e3-hacking@earth.li, Arun KS , "linux-serial@vger.kernel.org" , "linux-omap@vger.kernel.org" , Alan Cox List-Id: linux-serial@vger.kernel.org On Tue, Jul 28, 2009 at 06:36:01PM +0200, Janusz Krzysztofik wrote: > Tuesday 28 July 2009 18:11:32 Mark Brown wrote: > > Like I say, I'd suggest always keeping the controls registered and just > > masking and unmasking from user space - the control indexes get used so > > removing them will just confuse things. > However, in order for the machine driver to unmask/mask a machine specific > control, the codec driver must drop the machine driver a message about the > line discipline being activeted/deactivated, right? The only such existing > feedback I can see the codec is able to use is via snd_soc_init_card() that > calls snd_soc_dai_link.init() in turn. Am I missing something? Well, the machine driver can look up controls by name (this is going to be required in order to find the controls anyway...). Besides, given that the machine driver is already entirely CODEC-specific there'd no problem with it calling into CODEC-specific APIs to do things.