From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: fix htmldocs warnings
Date: Tue, 22 Sep 2009 15:09:15 -0700 [thread overview]
Message-ID: <20090922150915.8bcc203d.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1253657038.3187.1.camel@ht.satnam>
On Wed, 23 Sep 2009 03:33:58 +0530 Jaswinder Singh Rajput wrote:
>
> Warning(/home/jaswinder/linux-2.6//include/linux/serial_core.h:485): No description found for parameter 'uport'
> Warning(/home/jaswinder/linux-2.6//include/linux/serial_core.h:485): Excess function parameter 'port' description in 'uart_handle_dcd_change'
> Warning(/home/jaswinder/linux-2.6//include/linux/serial_core.h:511): No description found for parameter 'uport'
> Warning(/home/jaswinder/linux-2.6//include/linux/serial_core.h:511): Excess function parameter 'port' description in 'uart_handle_cts_change'
> Warning(/home/jaswinder/linux-2.6//drivers/serial/serial_core.c:2437): No description found for parameter 'uport'
> Warning(/home/jaswinder/linux-2.6//drivers/serial/serial_core.c:2437): Excess function parameter 'port' description in 'uart_add_one_port'
> Warning(/home/jaswinder/linux-2.6//drivers/serial/serial_core.c:2509): No description found for parameter 'uport'
> Warning(/home/jaswinder/linux-2.6//drivers/serial/serial_core.c:2509): Excess function parameter 'port' description in 'uart_remove_one_port'
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Ack. I've already sent the same patch.
> ---
> drivers/serial/serial_core.c | 4 ++--
> include/linux/serial_core.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
> index 2514d00..1689bda 100644
> --- a/drivers/serial/serial_core.c
> +++ b/drivers/serial/serial_core.c
> @@ -2426,7 +2426,7 @@ struct tty_driver *uart_console_device(struct console *co, int *index)
> /**
> * uart_add_one_port - attach a driver-defined port structure
> * @drv: pointer to the uart low level driver structure for this port
> - * @port: uart port structure to use for this port.
> + * @uport: uart port structure to use for this port.
> *
> * This allows the driver to register its own uart_port structure
> * with the core driver. The main purpose is to allow the low
> @@ -2499,7 +2499,7 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
> /**
> * uart_remove_one_port - detach a driver defined port structure
> * @drv: pointer to the uart low level driver structure for this port
> - * @port: uart port structure for this port
> + * @uport: uart port structure for this port
> *
> * This unhooks (and hangs up) the specified port structure from the
> * core driver. No further calls will be made to the low-level code
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index d58e460..fe661af 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -477,7 +477,7 @@ static inline int uart_handle_break(struct uart_port *port)
>
> /**
> * uart_handle_dcd_change - handle a change of carrier detect state
> - * @port: uart_port structure for the open port
> + * @uport: uart_port structure for the open port
> * @status: new carrier detect status, nonzero if active
> */
> static inline void
> @@ -503,7 +503,7 @@ uart_handle_dcd_change(struct uart_port *uport, unsigned int status)
>
> /**
> * uart_handle_cts_change - handle a change of clear-to-send state
> - * @port: uart_port structure for the open port
> + * @uport: uart_port structure for the open port
> * @status: new clear to send status, nonzero if active
> */
> static inline void
> --
> 1.6.0.6
>
>
---
~Randy
prev parent reply other threads:[~2009-09-22 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 22:03 [PATCH] serial: fix htmldocs warnings Jaswinder Singh Rajput
2009-09-22 22:09 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090922150915.8bcc203d.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).