From: Andrew Morton <akpm@linux-foundation.org>
To: "Richard Röjfors" <richard.rojfors@mocean-labs.com>
Cc: linux-serial@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH RESEND] timbuart: Support for beeing probed more than once
Date: Tue, 29 Sep 2009 16:20:20 -0700 [thread overview]
Message-ID: <20090929162020.e429c826.akpm@linux-foundation.org> (raw)
In-Reply-To: <4AB8C23B.3020309@mocean-labs.com>
On Tue, 22 Sep 2009 14:25:31 +0200
Richard R__jfors <richard.rojfors@mocean-labs.com> wrote:
> There was a problem in the current implementation where a global static
> uart_driver struct was used. The same struct was reused every time the
> driver got probed. Since the struct has a state within the serial core
> it can not be reused.
>
> A uart_driver struct is added to the timbuart_port struct which is
> allocated per platform device.
>
> The probe and remove functions are declared __devinit and __devexit.
Are you sure? Lots of other serial drivers appears to do it this way
and I'm ununaware of it causing any problems there.
Exactly what problem(s) are you observing? (This should have been
described in the original changelog btw).
next prev parent reply other threads:[~2009-09-29 23:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 12:25 [PATCH RESEND] timbuart: Support for beeing probed more than once Richard Röjfors
2009-09-29 23:20 ` Andrew Morton [this message]
2009-09-30 7:56 ` Richard Röjfors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090929162020.e429c826.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-serial@vger.kernel.org \
--cc=richard.rojfors@mocean-labs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).